-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(worker): inline es worker does not work in build mode #14307
Conversation
|
why the |
It seems to be a bug in Node: nodejs/node#49497 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you add a test in playground/worker?
I guess changing my-worker.ts and es-worker.spec.ts would work.
the tests added |
I rebased the branch and force-pushed as the diff view was huge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
new Worker(blobUrl,{type:'module'/*missed*/})
It should be configured as expected (fix:Inline Web Worker with format:es(type=module) does not work as expected in build mode #14306)revokeObjectURL
immediatelyAdditional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).