Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: enable generatedCode: 'es2015' for rollup build #5018

Merged
merged 7 commits into from
May 13, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Sep 22, 2021

Description

See https://twitter.com/lukastaegert/status/1440543481059938305

Additional context

Awaits #5045


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu force-pushed the feat/rollup-build branch 3 times, most recently from ae0ee6d to 739317b Compare September 23, 2021 06:13
@antfu antfu marked this pull request as draft September 23, 2021 06:14
@antfu antfu closed this Oct 21, 2021
@antfu antfu deleted the feat/rollup-build branch October 21, 2021 22:22
@antfu antfu restored the feat/rollup-build branch October 21, 2021 22:22
@antfu antfu reopened this Oct 21, 2021
@ckken
Copy link

ckken commented Nov 2, 2021

support es5?

@morlay
Copy link

morlay commented Nov 25, 2021

support es5?

It could. for old browser, we could use AMD/requirejs #5754
So for me, I already say farewell to Webpack.

@Shinigami92
Copy link
Member

  • Still relevant?
  • Should it get out of Draft?
  • Do we need tests?
  • Clarify why this is not part of plugin-legacy? Do I misunderstood something?

@patak-dev
Copy link
Member

@antfu we could merge this one, no? Tests are passing, was there an issue that prevented us from using it? I can't recall now.

@antfu antfu marked this pull request as ready for review May 9, 2022 23:34
@antfu
Copy link
Member Author

antfu commented May 9, 2022

We could merge it as long as the tests are passing I believe (it was failing for some reason)

@sapphi-red
Copy link
Member

I'm not sure about the failing test in the past, but I have pushed a commit which fixes the current failing test.

@antfu
Copy link
Member Author

antfu commented May 13, 2022

Thanks. And it seems like I can't approve my own PR 😅

@patak-dev patak-dev merged commit 46d5e67 into vitejs:main May 13, 2022
@antfu antfu deleted the feat/rollup-build branch May 13, 2022 11:07
@antfu antfu added this to the 3.0 milestone May 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants