-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: enable generatedCode: 'es2015'
for rollup build
#5018
Conversation
ae0ee6d
to
739317b
Compare
739317b
to
1f3b5b6
Compare
support es5? |
It could. for old browser, we could use AMD/requirejs #5754 |
|
@antfu we could merge this one, no? Tests are passing, was there an issue that prevented us from using it? I can't recall now. |
We could merge it as long as the tests are passing I believe (it was failing for some reason) |
I'm not sure about the failing test in the past, but I have pushed a commit which fixes the current failing test. |
Thanks. And it seems like I can't approve my own PR 😅 |
Description
See https://twitter.com/lukastaegert/status/1440543481059938305
Additional context
Awaits #5045
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).