Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(plugin-vue): change @rollup/pluginutils to dep from devDep #8154

Merged
merged 1 commit into from
May 13, 2022

Conversation

sapphi-red
Copy link
Member

Description

All other plugins in this repo has @rollup/pluginutils in dep instead of devDep.

"@rollup/pluginutils": "^4.2.1",

@rollup/pluginutils is a quite common dep among rollup plugins so I think it is better to have this not bundled to dedupe it.
Maybe it should be a dep also with Vite?

In addition, @rollup/pluginutils don't have many deps, only 2.
https://npm.anvaka.com/#/view/2d/%2540rollup%252Fpluginutils

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the dependencies Pull requests that update a dependency file label May 13, 2022
@antfu antfu enabled auto-merge (squash) May 13, 2022 05:38
@antfu antfu merged commit dcc8ea4 into vitejs:main May 13, 2022
@sapphi-red sapphi-red deleted the chore/vue-dep-rollup-plugin-utils branch May 13, 2022 05:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants