Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(create-vite): use framework brand glow color #8539

Merged
merged 3 commits into from
Jun 11, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jun 11, 2022

Description

Use brand color for framework presets

Ref: #8502 (comment)

Additional context

Also refactored lit's html structure, and other framwork's img attribute order to be consistent.

Also fix lit export extension

Examples:

image

image

image

image


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

Awesome! 😍

@patak-dev patak-dev merged commit 3a21a5e into vitejs:main Jun 11, 2022
@bluwy bluwy deleted the feat-logo-color branch June 11, 2022 09:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants