Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: resolve drive relative path #9097

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 14, 2022

Description

#8808 completely removed drive-relative path resolution behavior.
I removed this because I thought it was not intended: it was resolving using process.cwd() as a base, not the importer.

But I found that node.js supports drive-relative path resolution (nodejs/node#31710) and now I think this should be implemented.

This PR implements drive-relative path resolution (with the correct base). In addition, this PR adds absolute path resolution test.

Additional context

I tested the behavior of drive-relative path by:
$ node D:\foo.mjs on pwd = C:\

D:\foo.mjs

import '/bar.mjs'

console.log('foo.mjs')

D:\bar.js

console.log('bar.mjs')

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jul 14, 2022
@netlify
Copy link

netlify bot commented Jul 14, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 841301d
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62cf7fe7994513000957fb34

@patak-dev
Copy link
Member

@dominikg is this related to the issue you mentioned, would you confirm that this fix works for you?

@dominikg
Copy link
Contributor

confirmed. Tested it in a local vm. Error happens with vite-3 from registry but not with a local build of this branch.

@patak-dev patak-dev merged commit b393451 into vitejs:main Jul 14, 2022
@sapphi-red sapphi-red deleted the fix/resolve-drive-relative-path branch July 14, 2022 11:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants