Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: update dep types (fixes #9475) #9489

Merged
merged 3 commits into from
Aug 2, 2022
Merged

fix: update dep types (fixes #9475) #9489

merged 3 commits into from
Aug 2, 2022

Conversation

sapphi-red
Copy link
Member

Description

Updated inlined dep types.

fixes #9475

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-edge-case Bug, but has workaround or limited in scope (priority) label Aug 1, 2022
bluwy
bluwy approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually verified the changes. LGTM!

@bluwy bluwy merged commit 937cecc into vitejs:main Aug 2, 2022
@sapphi-red sapphi-red deleted the fix/update-dep-types branch August 2, 2022 06:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Milestone
No milestone
2 participants
@sapphi-red @bluwy