Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: node prefix lint #9514

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 3, 2022

Description

Used import/no-nodejs-modules and set all node prefixed modules to allow option.

This way we don't need to add an extra dep or maintain a rule.
As a disadvantage, auto-fix does not work. (But I think it's better than having no rules.)

Additional context

refs #8309


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Aug 3, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow neat!

@sapphi-red sapphi-red merged commit 9e9cd23 into vitejs:main Aug 3, 2022
@sapphi-red sapphi-red deleted the chore/node-prefix-lint branch August 3, 2022 13:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants