Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(create-vite): migrate to TypeScript #9941

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

sapphi-red
Copy link
Member

Description

Migrated create-vite to TypeScript for better maintainability.

I fixed @types/prompts version along this.
2.4.0 is a broken version (DefinitelyTyped/DefinitelyTyped#59890) and it seems it does not exist any more.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Sep 1, 2022
@patak-dev patak-dev merged commit 85fa2c8 into vitejs:main Sep 3, 2022
@sapphi-red sapphi-red deleted the refactor/create-vite-typescript branch September 4, 2022 07:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants