Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

React 19 support #8

Open
kossnocorp opened this issue Dec 9, 2024 · 2 comments
Open

React 19 support #8

kossnocorp opened this issue Dec 9, 2024 · 2 comments

Comments

@kossnocorp
Copy link

Hey! Thank you so much for this helpful library 🙏

There's a small problem, though. After upgrading to React 19, released a few days ago, it started breaking as it locks on React 18. I tested it on my project with React 19 by copying the source of vitest-browser-react code into my repo, as there's no need for any changes. It just works. I think you can safely expand the dependency version to include 19 and ship it as a new version.
@sheremet-va
Copy link
Member

Shouldn't "react": ">18.0.0" cover react 19?

@MatanBobi
Copy link
Contributor

I agree with @sheremet-va here, we have `"react": ">18.0.0" which allows these versions (taken from semver.npmjs.com):
image

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kossnocorp @MatanBobi @sheremet-va