Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: allow searching for people #231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

viniciuskloppel
Copy link

@viniciuskloppel viniciuskloppel commented Jan 19, 2025

This change allows the search function to handle searches for "People" by using parse_users when kv["product"] == "People", while retaining the default behavior for tweets.

@viniciuskloppel
Copy link
Author

Hey @vladkens, just to give you some context, I noticed that the search function could be extended to also search for people on X, since it's just another tab (or another kv["product"] in our case). This change makes the return type of the search function look like this: Generator[Tweet | User, Any, None].

Let me know if you think that's reasonable, or if you'd prefer to create a separate function for that (e.g., search_people).

@viginum-datalab
Copy link

Very nice work @viniciuskloppel !

@vladkens
Copy link
Owner

Hi, @viniciuskloppel. Looks nice. I just need to add parsing test case for new API and I will merge it soon.

@viniciuskloppel
Copy link
Author

Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants