Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: update to Go 1.24 #153

Merged
merged 5 commits into from
Feb 20, 2025
Merged

chore: update to Go 1.24 #153

merged 5 commits into from
Feb 20, 2025

Conversation

hugoh
Copy link
Contributor

@hugoh hugoh commented Feb 16, 2025 •
edited
Loading

I labeled this PR "feat" as "chore" didn't quite fit since I updated a test file.

hugoh added 2 commits February 15, 2025 19:38
@hugoh
golangci-lint fix
f1770d2 
test -f $(go env GOPATH)/bin/golangci-lint || curl -sSfL
https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh
| sh -s -- -b $(go env GOPATH)/bin v1.64.5
$(go env GOPATH)/bin/golangci-lint run ./...
WARN The linter 'tenv' is deprecated (since v1.64.0) due to: Duplicate
feature another linter. Replaced by usetesting.
pkg/testcoverage/badgestorer/github_test.go:92:3: context.Background()
could be replaced by t.Context() in deleteFile (usetesting)
                context.Background(),
                ^
pkg/testcoverage/badgestorer/github_test.go:101:3: context.Background()
could be replaced by t.Context() in deleteFile (usetesting)
                context.Background(),
                ^
make: *** [lint] Error 1
zsh: exit 2     make lint
@hugoh
Update to Go 1.24.0
63ee5ba
@hugoh hugoh changed the title Update to Go 1.24 minor: update to Go 1.24 Feb 16, 2025
@hugoh hugoh changed the title minor: update to Go 1.24 feat: update to Go 1.24 Feb 16, 2025
@vladopajic vladopajic changed the title feat: update to Go 1.24 chore: update to Go 1.24 Feb 16, 2025
@vladopajic
Copy link
Owner

hey,

in context of this repo feat should mean that PR has introduced new functionality for tool (users of go-test-coverage can now do something more that they haven't been able before). updating dependencies or tools is just general maintenance. for example, this repo in releases only includes feat or fix type of PRs because those only meter for users.

vladopajic
vladopajic reviewed Feb 16, 2025
View reviewed changes
@hugoh
Copy link
Contributor Author

hugoh commented Feb 20, 2025 •
edited
Loading

hey,

in context of this repo feat should mean that PR has introduced new functionality for tool (users of go-test-coverage can now do something more that they haven't been able before). updating dependencies or tools is just general maintenance. for example, this repo in releases only includes feat or fix type of PRs because those only meter for users.

I'll argue that Go 1.24 support does bring a new feature: I have a repo failing because of the use of go tool that doesn't exist in 1.23, but I'm fine either way.

@vladopajic vladopajic merged commit 7c12790 into vladopajic:main Feb 20, 2025
1 check passed
@vladopajic vladopajic mentioned this pull request Feb 20, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vladopajic vladopajic vladopajic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugoh @vladopajic