From 534e75c1193165605aee6d741deb4a1536c58ff1 Mon Sep 17 00:00:00 2001 From: Tomer Asida Date: Tue, 3 Sep 2024 16:46:16 +0300 Subject: [PATCH 1/2] fix: Add the +empty tag to the version only when the VLLM_TARGET_DEVICE envvar was explicitly set to "empty" --- setup.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 38d3f41663f2e..2efe3f3f1ce43 100644 --- a/setup.py +++ b/setup.py @@ -362,7 +362,8 @@ def get_vllm_version() -> str: version = find_version(get_path("vllm", "version.py")) if _no_device(): - version += "+empty" + if VLLM_TARGET_DEVICE == envs.VLLM_TARGET_DEVICE: + version += "+empty" elif _is_cuda(): cuda_version = str(get_nvcc_cuda_version()) if cuda_version != MAIN_CUDA_VERSION: From dd4a388affcbc278070262194cb1f6d1e0aaffc3 Mon Sep 17 00:00:00 2001 From: Tomer Asida Date: Tue, 3 Sep 2024 21:39:53 +0300 Subject: [PATCH 2/2] make the code more explicit --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 2efe3f3f1ce43..1e08a5bd70cd3 100644 --- a/setup.py +++ b/setup.py @@ -362,7 +362,7 @@ def get_vllm_version() -> str: version = find_version(get_path("vllm", "version.py")) if _no_device(): - if VLLM_TARGET_DEVICE == envs.VLLM_TARGET_DEVICE: + if envs.VLLM_TARGET_DEVICE == "empty": version += "+empty" elif _is_cuda(): cuda_version = str(get_nvcc_cuda_version())