-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(a11y): stepper-completed step does not have accessible notification after completion #1334
Conversation
👋 @andyfeds,
Thank you, 🤖 Clarity Release Bot |
Do we intend to backport this to v16? and to v15 if we do it before 28th of March (this is the end of support date for v15)? |
although we are adding new API - so this seems more like a "feat" rather than a "fix" to me, but it still is not a breaking change, so it could be backported |
Yeah, its not a breaking change, just changes the behaviour for screen readers. |
3d2a460
to
daeca79
Compare
…tion after completion - CDE-699 Authored-by: Andrea Fernandes <andrea.fernandes@broadcom.com>
Authored-by: Andrea Fernandes <andrea.fernandes@broadcom.com>
Authored-by: Andrea Fernandes <andrea.fernandes@broadcom.com>
…on after completion (#1334) ## PR Checklist Please check if your PR fulfills the following requirements: - [x] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? In the Stepper, when the step is complete, keyboard focus moves to the next step but there's no indication that the previous step is completed by the screen reader. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: [CDE-699](https://jira.eng.vmware.com/browse/CDE-699) ## What is the new behavior? The screen reader will announce that the current step is complete (or failed) and move focus to the next step or stay in the same step in case of an error. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Co-authored-by: Andrea Fernandes <andreaf1@vmware.com> (cherry picked from commit 0c02a7a)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1334-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0c02a7a2478763f9bc711d526a9ef9f81ffc6bc8
# Push it to GitHub
git push --set-upstream origin backport-1334-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.x Then, create a pull request where the |
…on after completion (backport to 15.x) (#1347) Backport 0c02a7a from #1334. <br> ## PR Checklist Please check if your PR fulfills the following requirements: - [x] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? In the Stepper, when the step is complete, keyboard focus moves to the next step but there's no indication that the previous step is completed by the screen reader. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: [CDE-699](https://jira.eng.vmware.com/browse/CDE-699) ## What is the new behavior? The screen reader will announce that the current step is complete (or failed) and move focus to the next step or stay in the same step in case of an error. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Co-authored-by: Andrea A Fernandes <andy2890@gmail.com>
…on after completion (vmware-clarity#1334) Please check if your PR fulfills the following requirements: - [x] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: In the Stepper, when the step is complete, keyboard focus moves to the next step but there's no indication that the previous step is completed by the screen reader. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: [CDE-699](https://jira.eng.vmware.com/browse/CDE-699) The screen reader will announce that the current step is complete (or failed) and move focus to the next step or stay in the same step in case of an error. - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> --------- Co-authored-by: Andrea Fernandes <andreaf1@vmware.com> (cherry picked from commit 0c02a7a)
…on after completion (#1334) (#1348) ## PR Checklist Please check if your PR fulfills the following requirements: - [x] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: In the Stepper, when the step is complete, keyboard focus moves to the next step but there's no indication that the previous step is completed by the screen reader. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: [CDE-699](https://jira.eng.vmware.com/browse/CDE-699) The screen reader will announce that the current step is complete (or failed) and move focus to the next step or stay in the same step in case of an error. - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> --------- Co-authored-by: Andrea Fernandes <andreaf1@vmware.com> --------- Co-authored-by: Andrea Fernandes <andreaf1@vmware.com>
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In the Stepper, when the step is complete, keyboard focus moves to the next step but there's no indication that the previous step is completed by the screen reader.
Issue Number: CDE-699
What is the new behavior?
The screen reader will announce that the current step is complete (or failed) and move focus to the next step or stay in the same step in case of an error.
Does this PR introduce a breaking change?
Other information