Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(alert): make neutral app-level alert action buttons visible #1445

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented Jun 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

Bugfix

What is the current behavior?

Action buttons in neutral app-level alerts are not visible.

https://stackblitz.com/edit/j3auoh?file=src%2Fapp%2Fexample.component.html

Issue Number: CDE-2089

What is the new behavior?

Action buttons in neutral app-level alerts are visible.

Does this PR introduce a breaking change?

No.

Other information

The @extend .btn-neutral-outline; was causing the neutral alert action buttons to have the wrong color. I removed the similar statements from all of the app-level alert types because it's not needed in any of them.

CDE-2089

The `@extend .btn-neutral-outline;` was causing the neutral alert action
buttons to have the wrong color. I removed this from all of the alert
type because it's not needed in any of them.

CDE-2089
@kevinbuhmann kevinbuhmann requested a review from a team June 13, 2024 17:15
@kevinbuhmann kevinbuhmann self-assigned this Jun 13, 2024
Copy link
Contributor

github-actions bot commented Jun 13, 2024

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

This PR introduces visual changes: 79e3c24
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout kevin/app-level-alert-action-vrt
git fetch https://github.com/vmware-clarity/ng-clarity.git 79e3c2420b1af4b35e238d1bc08fccc5007c84cd
git cherry-pick 79e3c2420b1af4b35e238d1bc08fccc5007c84cd
git push

@kevinbuhmann kevinbuhmann changed the title fix(alert): make neutral alert action buttons visible fix(alert): make neutral app-level alert action buttons visible Jun 14, 2024
@kevinbuhmann kevinbuhmann merged commit 07f2892 into main Jun 14, 2024
7 checks passed
@kevinbuhmann kevinbuhmann deleted the kevin/app-level-alert-action-vrt branch June 14, 2024 00:43
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants