-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(spinner): override wrong tokens mapping #1500
Conversation
👋 @mivaylo,
Thank you, 🤖 Clarity Release Bot |
Follow up of #1488 |
This PR introduces visual changes: 407570f
|
This PR introduces visual changes: 37a273e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check my comments
8bb90e3
to
3184036
Compare
This PR introduces visual changes: efd9764
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Check my comment.
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-1513
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Spinner inverse tokens were correct but their mapping to the global ones is wrong. This overrides the wrong mapping and these tokens are not used in other places so we are safe with the fix.
Update: after discussion with @valentin-mladenov and design team we've found out that two more tokens have incorrect mapping, so we are adding them too in this PR.
Another improvement that the PR includes is providing a more meaningful demo for the inverse spinner (with proper background) in the demo app and the storybook