fix(modal): provide modal config service in root and export #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
Jinnie
approved these changes
Sep 19, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
## What is the current behavior?
The following error occurs when using `VmwNgxModalService`:
```
ERROR NullInjectorError: R3InjectorError(Environment Injector)[ClrModalConfigurationService -> ClrModalConfigurationService]:
NullInjectorError: No provider for ClrModalConfigurationService!
at NullInjector.get (core.mjs:1635:21)
at R3Injector.get (core.mjs:3017:27)
at R3Injector.get (core.mjs:3017:27)
at ChainedInjector.get (core.mjs:5288:32)
at lookupTokenUsingModuleInjector (core.mjs:5631:31)
at getOrCreateInjectable (core.mjs:5677:10)
at ɵɵdirectiveInject (core.mjs:11586:17)
at NodeInjectorFactory.ClrModal_Factory [as factory] (clr-angular.mjs:32885:177)
at getNodeInjectable (core.mjs:5871:38)
at instantiateAllDirectives (core.mjs:12403:23)
```
Issue Number: CDE-2293
## What is the new behavior?
No error occurs when using `VmwNgxModalService`.
(cherry picked from commit 29eed4c)
kevinbuhmann
added a commit
that referenced
this pull request
Sep 19, 2024
This is a backport of 29eed4c (#1556) to 16.x. ## What is the current behavior? The following error occurs when using `VmwNgxModalService`: ``` ERROR NullInjectorError: R3InjectorError(Environment Injector)[ClrModalConfigurationService -> ClrModalConfigurationService]: NullInjectorError: No provider for ClrModalConfigurationService! at NullInjector.get (core.mjs:1635:21) at R3Injector.get (core.mjs:3017:27) at R3Injector.get (core.mjs:3017:27) at ChainedInjector.get (core.mjs:5288:32) at lookupTokenUsingModuleInjector (core.mjs:5631:31) at getOrCreateInjectable (core.mjs:5677:10) at ɵɵdirectiveInject (core.mjs:11586:17) at NodeInjectorFactory.ClrModal_Factory [as factory] (clr-angular.mjs:32885:177) at getNodeInjectable (core.mjs:5871:38) at instantiateAllDirectives (core.mjs:12403:23) ``` Issue Number: CDE-2293 ## What is the new behavior? No error occurs when using `VmwNgxModalService`. Co-authored-by: Kevin Buhmann <kbuhmann@vmware.com>
|
🎉 This PR is included in version 17.3.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a dependency injection error when using the
VmwNgxModalService.PR Checklist
PR Type
Bugfix
What is the current behavior?
The following error occurs when using
VmwNgxModalService:Issue Number: CDE-2293
What is the new behavior?
No error occurs when using
VmwNgxModalService.Does this PR introduce a breaking change?
No.