Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(wizard): improve wizard step status indicator for color-blind users #1557

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented Sep 19, 2024

CDE-2282

PR Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

Bugfix

What is the current behavior?

There is no gap between wizard step status indicator colors. This makes the design difficult to view for color-blind users. This is also a divergence from the documentation which explicitly calls out the need for a gap.

Issue Number: CDE-2282

What is the new behavior?

There is now a 1px gap between wizard step status indicator colors. This makes the design easier to view for color-blind users. This also makes the component consistent with the documentation which explicitly calls out the need for a gap.

Does this PR introduce a breaking change?

No.

Copy link
Contributor

github-actions bot commented Sep 19, 2024

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann force-pushed the kevin/wizard-status-1px-gap branch from c6ee908 to da01fa5 Compare September 19, 2024 09:40

This comment was marked as resolved.

@kevinbuhmann kevinbuhmann changed the title fix(wizard): add 1px gap between wizard step status indicator colors fix(wizard): improve wizard step status indicator for color-blind users Sep 19, 2024
@kevinbuhmann kevinbuhmann requested a review from a team September 24, 2024 07:18
Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbuhmann kevinbuhmann merged commit dc65030 into main Sep 24, 2024
8 checks passed
@kevinbuhmann kevinbuhmann deleted the kevin/wizard-status-1px-gap branch September 24, 2024 09:19
Copy link
Contributor

github-actions bot commented Oct 2, 2024

🎉 This PR is included in version 17.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants