Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(tokens): temp overrride for warning status dark color for dark theme #1611

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

--cds-alias-status-warning-dark have --cds-global-color-ochre-700 for dark theme.

Issue Number: CDE-2402

What is the new behavior?

--cds-alias-status-warning-dark have --cds-global-color-ochre-600 for dark theme.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov requested a review from a team November 5, 2024 09:06
@valentin-mladenov valentin-mladenov self-assigned this Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@valentin-mladenov
Copy link
Contributor Author

Follow up of vmware-clarity/core#338

@valentin-mladenov valentin-mladenov changed the title fix(tokens): warning status dark color for dark theme fix(tokens): temp overrride for warning status dark color for dark theme Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This PR introduces visual changes: 3ec7802
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout change-warning-status-dark_cde-2402
git fetch https://github.com/vmware-clarity/ng-clarity.git 3ec7802d3a2bdae1f2db1e7c2a0e5320bd3d33eb
git cherry-pick 3ec7802d3a2bdae1f2db1e7c2a0e5320bd3d33eb
git push

@valentin-mladenov valentin-mladenov marked this pull request as ready for review November 5, 2024 12:10
@valentin-mladenov valentin-mladenov merged commit aeec806 into main Nov 6, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the change-warning-status-dark_cde-2402 branch November 6, 2024 11:19
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants