feat(datagrid): add string filter label

[valentin-mladenov]

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Datagrid filter dialog window have no title.

Issue Number: CDE-2483

What is the new behavior?

Datagrid string filter dialog window have label similar to number filter dialog.

Does this PR introduce a breaking change?

• Yes
• No

Other information

[github-actions]

👋 @valentin-mladenov,

• 🙏 The Clarity team thanks you for opening a pull request
• 🎉 The build for this PR has succeeded
• 🔍 The PR is now ready for review
• 🍿 In the meantime, view a preview of this PR
• 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

[github-actions]

This PR introduces visual changes: b0c3885
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-filter-title_cde-2483
git fetch https://github.com/vmware-clarity/ng-clarity.git b0c3885762da2cfea8ca61a279a98a673559f618
git cherry-pick b0c3885762da2cfea8ca61a279a98a673559f618
git push

[github-actions]

This PR introduces visual changes: 93d8fa1
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-filter-title_cde-2483
git fetch https://github.com/vmware-clarity/ng-clarity.git 93d8fa1478ab9ad7e4f7a925fe6a024fa31b59ef
git cherry-pick 93d8fa1478ab9ad7e4f7a925fe6a024fa31b59ef
git push

[github-actions]

This PR introduces visual changes: 8dd2c8d
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-filter-title_cde-2483
git fetch https://github.com/vmware-clarity/ng-clarity.git 8dd2c8de89bebc62cfea8d1500f877b7fb8f00ac
git cherry-pick 8dd2c8de89bebc62cfea8d1500f877b7fb8f00ac
git push

[kevinbuhmann]

See comments.

Also, the filter form control labels are larger than the filter popup title. I don't think that's correct.

[valentin-mladenov]

See comments.

Also, the filter form control labels are larger than the filter popup title. I don't think that's correct.

The filter title is following the signpost title design spec. I'll double check with design.

[github-actions]

This PR introduces visual changes: 2d32232
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-filter-title_cde-2483
git fetch https://github.com/vmware-clarity/ng-clarity.git 2d322326c911955c4bc44503948117750c503950
git cherry-pick 2d322326c911955c4bc44503948117750c503950
git push

[github-actions]

This PR introduces visual changes: 95a3c6a
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-filter-title_cde-2483
git fetch https://github.com/vmware-clarity/ng-clarity.git 95a3c6a0a12bd988d77269a1cb87d50c3d1d18cd
git cherry-pick 95a3c6a0a12bd988d77269a1cb87d50c3d1d18cd
git push

[valentin-mladenov]

@kevinbuhmann the acceptance criteria is changed. The implementation is totaly different.

[github-actions]

This PR introduces visual changes: e3af749
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout datagrid-filter-title_cde-2483
git fetch https://github.com/vmware-clarity/ng-clarity.git e3af749956cacad821312117f812cc6f79e8bde8
git cherry-pick e3af749956cacad821312117f812cc6f79e8bde8
git push

[github-actions]

🎉 This PR is included in version 17.6.0 🎉

The release is available on:

• GitHub release
• v17.6.0

Your semantic-release bot 📦🚀

[github-actions]

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.