Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(forms): add full width class #1710

Merged
merged 3 commits into from
Feb 24, 2025
Merged

feat(forms): add full width class #1710

merged 3 commits into from
Feb 24, 2025

Conversation

dtsanevmw
Copy link
Contributor

@dtsanevmw dtsanevmw commented Feb 20, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

Introduces a new class that can be set on the forms so that controls can take full width of the container or take control on them with utility classes clr-col-*

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2572

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Feb 20, 2025

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/cde-2572 branch 6 times, most recently from e60afb8 to 47661f0 Compare February 24, 2025 09:39
@vmware-clarity vmware-clarity deleted a comment from github-actions bot Feb 24, 2025
@vmware-clarity vmware-clarity deleted a comment from github-actions bot Feb 24, 2025
@vmware-clarity vmware-clarity deleted a comment from github-actions bot Feb 24, 2025
@vmware-clarity vmware-clarity deleted a comment from github-actions bot Feb 24, 2025
@vmware-clarity vmware-clarity deleted a comment from github-actions bot Feb 24, 2025
@dtsanevmw dtsanevmw marked this pull request as ready for review February 24, 2025 09:47
Copy link
Contributor

This PR introduces visual changes: 5204e3e
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/cde-2572
git fetch https://github.com/vmware-clarity/ng-clarity.git 5204e3e78590f052284f92050aef918de3b0b6d6
git cherry-pick 5204e3e78590f052284f92050aef918de3b0b6d6
git push

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add .clr-form-full-width class to styles.md file

@dtsanevmw dtsanevmw merged commit 0b27cad into main Feb 24, 2025
12 checks passed
@dtsanevmw dtsanevmw deleted the dtsanevmw/cde-2572 branch February 24, 2025 15:25
Copy link
Contributor

🎉 This PR is included in version 17.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants