Cleanup use of GetClientConfigNoLock()

[marckhouzam]

Cleanup

There was a need for a quick fix for failing tests which was done in #3177.
Now that the tests are unblocked, we should probably cleanup the use of GetClientConfigNoLock() which is always preceded by calls to

AcquireTanzuConfigLock()
defer ReleaseTanzuConfigLock()

and instead use GetClientConfig() directly,

We could even consider making AcquireTanzuConfigLock() and ReleaseTanzuConfigLock() private.

There may be other aspects of that API that I don't understand, so take my suggestion with a grain of salt.

Affected product area (please put an X in all that apply)

• (x) CLI

Version (include the SHA if the version is not obvious)

Latest main: af5a644

[marckhouzam]

This is wrong. Using GetClientConfig() directly does not retain the lock and therefore does not lock the config file past the reading of it. @anujc25 gave a good explanation here #3665 (comment)