Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Refactor tkg to fix linter issues #3478

Open
chandrareddyp opened this issue Sep 23, 2022 · 0 comments
Open

Refactor tkg to fix linter issues #3478

chandrareddyp opened this issue Sep 23, 2022 · 0 comments
Assignees
Labels
area/testing CI kind/bug PR/Issue related to a bug

Comments

@chandrareddyp
Copy link
Contributor

chandrareddyp commented Sep 23, 2022

Bug description
The tkg package and its sub-packages have linter issues which are skipped for now as part of PR #3450. The code needs to be refactored to fix the linter issues specific to funlen and gocyclo
Here are list of files which has funlen and gocyclo issues and skipped as part of the PR #3450:
tkg/client/machine_deployment_cc.go
tkg/client/upgrade_region.go
tkg/tkgctl/create_cluster.go

Affected product area (please put an X in all that apply)

  • ( ) APIs
  • ( ) Addons
  • (X) CLI
  • ( ) Docs
  • ( ) IAM
  • ( ) Installation
  • ( ) Plugin
  • ( ) Security
  • ( ) Test and Release
  • ( ) User Experience
  • ( ) Developer Experience

Expected behavior
The make lint should not return any linter funlen and gocyclo issues
Steps to reproduce the bug

Version (include the SHA if the version is not obvious)

Environment where the bug was observed (cloud, OS, etc)

Relevant Debug Output (Logs, manifests, etc)

@chandrareddyp chandrareddyp added kind/bug PR/Issue related to a bug needs-triage Indicates an issue or PR needs to be triaged labels Sep 23, 2022
@vuil vuil added CI area/testing and removed needs-triage Indicates an issue or PR needs to be triaged labels Oct 7, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/testing CI kind/bug PR/Issue related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants