Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Linter simplification #4326

Open
jayunit100 opened this issue Feb 3, 2023 · 0 comments
Open

Linter simplification #4326

jayunit100 opened this issue Feb 3, 2023 · 0 comments
Labels
area/framework area/release area/testing kind/bug PR/Issue related to a bug

Comments

@jayunit100
Copy link
Contributor

Bug description

  1. I have jobs that fail on make lint. Its not clear why, and i havent been able to isolate why.

Example of one of the errors...

Error: client/common.go:365:10: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)

  1. It appears that lint jobs take 25 minutes. Are we "overlinting"... can we just lint less?

  2. I cant reproduce these errors in CI locally

  3. I noticed if i export GO variables... somehow the linter starts to work locally

export GOPATH
export GOROOT
  • Can we lint less ?
  • Can we we run lint entirely in docker to avoid local GOPATH errors ?
@jayunit100 jayunit100 added kind/bug PR/Issue related to a bug needs-triage Indicates an issue or PR needs to be triaged labels Feb 3, 2023
@codegold79 codegold79 added area/release area/testing area/framework and removed needs-triage Indicates an issue or PR needs to be triaged labels Apr 4, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
area/framework area/release area/testing kind/bug PR/Issue related to a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayunit100 @codegold79