Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Optimize TestVolumeProperties #1096

Closed
pdhamdhere opened this issue Mar 27, 2017 · 2 comments
Closed

Optimize TestVolumeProperties #1096

pdhamdhere opened this issue Mar 27, 2017 · 2 comments
Labels
kind/enhancement kind/test P0
Milestone
0.16

Comments

@pdhamdhere
Copy link
Contributor

TestVolumeProperties test takes more than a minute.

We run following sequence thrice (for each disk type "thin", "zeroedthick", "eagerzeroedthick");

  1. Create volume (docker volume create --driver=vsphere ...
  2. Verify size, disk-format type and attached-status with Admin CLI
  3. Compare same properties with Docker CLI
  4. Start busybox with volume attached
  5. Repeat verification from Step 2
  6. Repeat verification from Step 3

Step 4-6 can be independent test with "thin" volume type. No need to repeat these steps for each disk-type.
@pdhamdhere pdhamdhere added this to the v1 GA milestone Mar 27, 2017
@tusharnt tusharnt modified the milestones: 0.15, v1 GA May 2, 2017
@shuklanirdesh82 shuklanirdesh82 mentioned this issue May 16, 2017
Merged
@shuklanirdesh82
Copy link
Contributor

@ashahi1

As we have gocheck testing framework, let's have a plan to use gocheck instead of go testing so it will be easier to manage testcases.

Please prioritize this task to finish as part of 0.15 milestone.

Thanks.

/CC @tusharnt

@shuklanirdesh82 shuklanirdesh82 mentioned this issue May 25, 2017
Merged
shuklanirdesh82 added a commit to shuklanirdesh82/vsphere-storage-for-docker that referenced this issue May 26, 2017
@shuklanirdesh82
Supplying change for Issues (vmware-archive#1294, vmware-archive#1301)
b97898c 
- removing reference of verification.ExecCmd
- little bit code cleanup for Issue vmware-archive#1096
- Introducing retry mechanism to look for vm power state changed
This was referenced May 26, 2017
Merged
Closed
shuklanirdesh82 added a commit that referenced this issue May 26, 2017
@shuklanirdesh82
Handling cleanup properly for vmlistener test (#1298) (#1300)
79d50a0 
* Handling cleanup properly for vmlistener test (#1298)

* Supplying change for Issues (#1294, #1301)

- removing reference of verification.ExecCmd
- little bit code cleanup for Issue #1096
- Introducing retry mechanism to look for vm power state changed
@shuklanirdesh82 shuklanirdesh82 mentioned this issue May 30, 2017
Closed
@ashahi1 ashahi1 mentioned this issue May 30, 2017
Merged
@ashahi1 ashahi1 modified the milestones: 0.16 , 0.15 May 31, 2017
@tusharnt tusharnt modified the milestones: 0.16 , 0.15 May 31, 2017
@tusharnt tusharnt added P0 and removed P1 labels May 31, 2017
@shuklanirdesh82
Copy link
Contributor

close via #1310

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
kind/enhancement kind/test P0
Projects
None yet
Milestone
0.16
Development

No branches or pull requests
4 participants
@tusharnt @pdhamdhere @shuklanirdesh82 @ashahi1