Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Log config changes for vDVS driver are not applied on CI #1160

Closed
2 tasks done
shuklanirdesh82 opened this issue Apr 10, 2017 · 0 comments · Fixed by #1600
Closed
2 tasks done

Log config changes for vDVS driver are not applied on CI #1160

shuklanirdesh82 opened this issue Apr 10, 2017 · 0 comments · Fixed by #1600

Comments

@shuklanirdesh82
Copy link
Contributor

shuklanirdesh82 commented Apr 10, 2017

Accommodate log_config.json changes on CI

As per following code, any changes to log_config.json file from the PR is not in effect if the older log_config.json present on ESX (CI system)

https://github.com/vmware/docker-volume-vsphere/blob/master/esx_service/utils/log_config.py#L80

def configure(config_file=LOG_CONFIG_FILE):
    """
    Checks if the json config file exists, and if it does not, creates it from
    hardcoded defaults. Then loads log config from the  file.
    Returns log file name.
    """
    generatedConf = False
    # if the conf file is not there, create it:
    if not os.path.isfile(config_file):

Need to correct deploy_tools.sh as well; desploy_esx shouldn't be responsible for cleaning up any leftover from the VIB installation.

  • The ideal way to achieve is removing older files from CI's ESX vms > recreate snapshots > improve cleanESX routine.

  • Need to remove following lines

  1. https://github.com/vmware/docker-volume-vsphere/blob/master/misc/scripts/deploy-tools.sh#L156
  2. https://github.com/vmware/docker-volume-vsphere/blob/master/misc/scripts/deploy-tools.sh#L216

/CC @msterin @lipingxue

@shuklanirdesh82 shuklanirdesh82 added this to the v1 GA milestone Apr 10, 2017
@shuklanirdesh82 shuklanirdesh82 self-assigned this Apr 10, 2017
@shuklanirdesh82 shuklanirdesh82 modified the milestones: 0.16 , v1 GA Jun 1, 2017
@shaominchen shaominchen modified the milestones: 0.17, 0.16 Jun 20, 2017
@tusharnt tusharnt modified the milestones: Biweekly sprint - Timon, 0.17 Jul 17, 2017
@shuklanirdesh82 shuklanirdesh82 changed the title Accommodate log_config.json changes on CI Log config changes for vDVS driver are not applied on CI Jul 17, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.