You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
def configure(config_file=LOG_CONFIG_FILE):
"""
Checks if the json config file exists, and if it does not, creates it from
hardcoded defaults. Then loads log config from the file.
Returns log file name.
"""
generatedConf = False
# if the conf file is not there, create it:
if not os.path.isfile(config_file):
Need to correct deploy_tools.sh as well; desploy_esx shouldn't be responsible for cleaning up any leftover from the VIB installation.
The ideal way to achieve is removing older files from CI's ESX vms > recreate snapshots > improve cleanESX routine.
Accommodate log_config.json changes on CI
As per following code, any changes to
log_config.json
file from the PR is not in effect if the olderlog_config.json
present on ESX (CI system)https://github.com/vmware/docker-volume-vsphere/blob/master/esx_service/utils/log_config.py#L80
Need to correct
deploy_tools.sh
as well; desploy_esx shouldn't be responsible for cleaning up any leftover from the VIB installation.The ideal way to achieve is removing older files from CI's ESX vms > recreate snapshots > improve cleanESX routine.
Need to remove following lines
/CC @msterin @lipingxue
The text was updated successfully, but these errors were encountered: