Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Review the use of handle_stale_attach #1201

Closed
pshahzeb opened this issue Apr 27, 2017 · 2 comments
Closed

Review the use of handle_stale_attach #1201

pshahzeb opened this issue Apr 27, 2017 · 2 comments
Assignees
@govint
Labels
kind/bug kind/test P1

Comments

@pshahzeb
Copy link
Contributor

After #1168,
The status of volume is updated at the poweroff event for VMs. This change makes handle_stale_attach in vmdk_ops useless. Get rid of the this check.
This should indirectly fix #1191. Because metadata reset happens in handle_stale_attach when VM to which a volume is attached isn't found (in shared db mode, the vm might reside on another host and hence won't be able to find)
@pshahzeb pshahzeb mentioned this issue Apr 27, 2017
Merged
@pdhamdhere pdhamdhere added this to the 0.15 milestone May 2, 2017
@tusharnt tusharnt assigned govint and unassigned pshahzeb May 12, 2017
@govint
Copy link
Contributor

govint commented May 24, 2017

Prioritizing #1262 for now to get those test cases implemented. Have made the changes based on last round of reviews, needs testing and then will push the changes again.

@tusharnt tusharnt modified the milestones: 0.15, 0.16 , 0.17 May 26, 2017
@govint
Copy link
Contributor

govint commented Jun 23, 2017

Closing

@govint govint closed this as completed Jun 23, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@govint govint

Labels
kind/bug kind/test P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tusharnt @govint @pdhamdhere @pshahzeb