Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Refactor common code between photon_driver.go and vmdk_driver.go #1212

Closed
pshahzeb opened this issue May 2, 2017 · 2 comments
Closed

Refactor common code between photon_driver.go and vmdk_driver.go #1212

pshahzeb opened this issue May 2, 2017 · 2 comments
Assignees
@pshahzeb
Labels
invalid

Comments

@pshahzeb
Copy link
Contributor

pshahzeb commented May 2, 2017

A big amount of code is common in these two files. Need to refactor them and place the common part in a common placeholder.
@pshahzeb pshahzeb added this to the v1 GA milestone May 2, 2017
This was referenced May 2, 2017
Merged
Merged
@govint
Copy link
Contributor

govint commented May 9, 2017

The Create() and Mount() are possibly the only functions that are mostly similar in actions between Photon and the VMDK driver. Rest are specific to use the Photon Controller API and not really separable into common code between the two.

@tusharnt tusharnt modified the milestones: Sprint - Rafiki, v1 GA Jul 25, 2017
@shuklanirdesh82
Copy link
Contributor

based on #1212 (comment) ... adding invalid keyword

@shuklanirdesh82 shuklanirdesh82 removed this from the Sprint - Rafiki milestone Sep 19, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@pshahzeb pshahzeb

Labels
invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tusharnt @govint @shuklanirdesh82 @pshahzeb