Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

tests/utils/dockercli/volumelifecycle.go:DeleteVolume() must not make multiple attempts to delete a volume #1413

Closed
govint opened this issue Jun 14, 2017 · 1 comment

Comments

@govint
Copy link
Contributor

govint commented Jun 14, 2017

A volume delete must work the first time if its not already in use. A failed attempt to delete a volume implies an issue and hence unnecessary to keep attempting a delete that has already failed.

@shuklanirdesh82 @shaominchen - this was added to handle a test error, but ideally the specific test should make retries and not this function.

Its a small change and I'll post the PR shortly.

@govint
Copy link
Contributor Author

govint commented Jun 14, 2017

Closing, will open if needed post offline discussion.

@govint govint closed this as completed Jun 14, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

1 participant