Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

[Debuggability] Show VM name in error message and logs #1702

Closed
pshahzeb opened this issue Aug 6, 2017 · 1 comment
Closed

[Debuggability] Show VM name in error message and logs #1702

pshahzeb opened this issue Aug 6, 2017 · 1 comment
Assignees
@shuklanirdesh82
Labels
customer kind/usability
Milestone
Sprint - Rafiki

Comments

@pshahzeb
Copy link
Contributor

pshahzeb commented Aug 6, 2017

Currently VM uuid is shown in case of errors.
For example: error during volume attach is as follows:

docker: Error response from daemon: error while mounting volume '/var/lib/docker/plugins/07edacf1891edd3b20bd2a3cc91439b73cc449822d4df431b7c14bc5212c3cef/rootfs/mnt/vmdk/mark': VolumeDriver.Mount: Failed to add disk 'scsi1:0'. disk /vmfs/volumes/sp-sys-docker/dockvols/_DEFAULT/mark.vmdk already attached to VM=5010dd5f-26b8-3719-2032-f8a8432a106c.

Since these errors are also logged (if not we need to do them), the name can be used in logs as well.
@pshahzeb pshahzeb self-assigned this Aug 6, 2017
@pdhamdhere pdhamdhere added this to the Sprint - Pumbaa milestone Aug 6, 2017
@tusharnt tusharnt assigned shuklanirdesh82 and unassigned pshahzeb Aug 7, 2017
@tusharnt tusharnt changed the title Show VM name in error message and logs [Debuggability] Show VM name in error message and logs Aug 16, 2017
@shuklanirdesh82
Copy link
Contributor

shuklanirdesh82 commented Aug 21, 2017 •
edited
Loading

While talking with @pshahzeb figured out that

  • Improve error message for attach/delete volume workflow (as of now - will be updated missing workflow).

  • Add common util which converts to vmName from vmUUID.

Refreshing the estimate.

shuklanirdesh82 added a commit to shuklanirdesh82/vsphere-storage-for-docker that referenced this issue Sep 20, 2017
@shuklanirdesh82
Improving error message to show VM name instead of VM UUID (vmware-ar…
acfa3ca 
…chive#1702)
@shuklanirdesh82 shuklanirdesh82 mentioned this issue Sep 20, 2017
Merged
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@shuklanirdesh82 shuklanirdesh82

Labels
customer kind/usability
Projects
None yet
Milestone
Sprint - Rafiki
Development

No branches or pull requests
4 participants
@tusharnt @pdhamdhere @shuklanirdesh82 @pshahzeb