Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

[Debuggability/Serviceability] Add logging for important workflows #1709

Closed
pdhamdhere opened this issue Aug 6, 2017 · 0 comments
Closed

Comments

@pdhamdhere
Copy link
Contributor

We do not log error in Plugin for "Get" request;

	status, err := d.GetVolume(r.Name)
	if err != nil {                              <<<<<No logging
		return volume.Response{Err: err.Error()}
	}
func (d *VolumeDriver) GetVolume(name string) (map[string]interface{}, error) {
	return d.ops.Get(name)
}
func (v VmdkOps) Get(name string) (map[string]interface{}, error) {
	log.Debugf("vmdkOps.Get name=%s", name)
	str, err := v.Cmd.Run("get", name, make(map[string]string))
	if err != nil {            <<<<< No logging
		return nil, err
	}
@pdhamdhere pdhamdhere added this to the Sprint - Pumbaa milestone Aug 6, 2017
@tusharnt tusharnt assigned govint and unassigned shaominchen Aug 9, 2017
@tusharnt tusharnt changed the title Log errors on "Get" request in Plugin Multiple "Get" requests empty volume name after Docker restart Aug 9, 2017
@tusharnt tusharnt added P1 and removed P0 labels Aug 9, 2017
@tusharnt tusharnt changed the title Multiple "Get" requests empty volume name after Docker restart [Debuggability/Serviceability] Add logging for important workflows Aug 9, 2017
@tusharnt tusharnt added P0 and removed P1 labels Aug 9, 2017
@govint govint closed this as completed Aug 11, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

4 participants