Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Support python lint for the automated builds. #351

Closed
govint opened this issue May 14, 2016 · 5 comments
Closed

Support python lint for the automated builds. #351

govint opened this issue May 14, 2016 · 5 comments

Comments

@govint
Copy link
Contributor

govint commented May 14, 2016

Install pylint in the docker image, Invoke lint on esx_service/Makefile.

@msterin msterin added this to the v1 GA milestone May 17, 2016
@govint
Copy link
Contributor Author

govint commented May 17, 2016

Add test code for pylint as well, the function calling style of naming the arg names in the calls makes it necessary to go fix every site that calls a function in the python code. Its not universally followed in all of the python code but is a source of failures.

@msterin
Copy link
Contributor

msterin commented Nov 9, 2016

As #721 indicates, we drift from good state pretty fast. Elevating priority and assigning to myself, will do ASAP

@govint
Copy link
Contributor Author

govint commented Nov 9, 2016

There are a lot of errors reported by pylint on syntax. Possibly, this needs to be a make target and a checklist in a PR to have pylint verified for at least new code.

@msterin
Copy link
Contributor

msterin commented Nov 9, 2016

I plan to make build fail if pylint returns errors. We will start adding more checks and warning after that

@msterin
Copy link
Contributor

msterin commented Nov 19, 2016

Fixed by #739

@msterin msterin closed this as completed Nov 19, 2016
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

4 participants