Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

The max_volume_size can be set a value even bigger than the total_size #673

Closed
shaominchen opened this issue Nov 1, 2016 · 2 comments
Closed
Assignees
Milestone

Comments

@shaominchen
Copy link
Contributor

The max_volume_size can be set a value even bigger than the total_size:

[root@localhost:/usr/lib/vmware/vmdkops/bin] vmdkops_admin tenant access add --name MyTenant --datastore datastore1 --volume-totalsize 1GB --rights create,delete --volume-maxsize 2GB
{'mount_volume': 0, 'global_visibility': 0, 'max_volume_size': 2048, 'create_volume': 1, 'delete_volume': 1, 'datastore': 'datastore1', 'usage_quota': 1024}
tenant access add succeeded
[root@localhost:/usr/lib/vmware/vmdkops/bin] vmdkops_admin tenant access ls --name MyTenant
Datastore Create_volume Delete_volume Mount_volume Max_volume_size Total_size


datastore1 1 1 0 2.00GB 1.00GB

We should add some parameter validation logic to prevent wrong configuration.

@lipingxue @msterin

@lipingxue
Copy link
Contributor

Hi Sam,
Could you take a look and working on this fix? Let me know if need any help from me.

@shaominchen
Copy link
Contributor Author

Sure Liping, I will take care of this.

@pdhamdhere pdhamdhere added this to the 0.9 milestone Nov 4, 2016
shaominchen pushed a commit that referenced this issue Nov 15, 2016
@shaominchen shaominchen modified the milestones: 0.10, 0.9 Nov 19, 2016
@pdhamdhere pdhamdhere modified the milestones: v1 GA, 0.10 Feb 1, 2017
shaominchen pushed a commit that referenced this issue Feb 2, 2017
1. Add logic to check the validity of privilege prameters
2. Add test cases to cover new logic
shaominchen pushed a commit that referenced this issue Feb 3, 2017
* Fix issue #673

1. Add logic to check the validity of privilege parameters
2. Add test cases to cover new logic
3. Refactored some test cases
4. Remove all trailing spaces in auth_api.py and error_code.py
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

3 participants