Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

vmdk_ops.py:removeVMDK() must check that a volume isn't in use before even attempting to remove it. #719

Closed
govint opened this issue Nov 8, 2016 · 3 comments · Fixed by #720

Comments

@govint
Copy link
Contributor

govint commented Nov 8, 2016

Add check for usage before disk is removed.

@msterin
Copy link
Contributor

msterin commented Nov 9, 2016

Before we introduced KV files there was no need to check, as the VMX and VMFS locks were checking it for us. With sidecar KVs, we planned to rely on sidecar / vmdk transactionality (that, in fact, was top reason to pick up sidecars). Unfortunately it is not working as promised, but my suggestion would be to just recover KV file if removeVMDK fails - it will have to happen very unfrequently, while check for usage will have to happen every time.

@govint
Copy link
Contributor Author

govint commented Nov 9, 2016

This is a bug in the way a disk unlink is working presently. Looks like the fix is part of #716 so, I'll close this one.

@govint govint closed this as completed Nov 9, 2016
@pdhamdhere pdhamdhere reopened this Feb 22, 2017
@pdhamdhere
Copy link
Contributor

Opened accidentally.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants