Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Need to fix errors found by pylint #721

Closed
msterin opened this issue Nov 9, 2016 · 0 comments · Fixed by #725
Closed

Need to fix errors found by pylint #721

msterin opened this issue Nov 9, 2016 · 0 comments · Fixed by #725

Comments

@msterin
Copy link
Contributor

msterin commented Nov 9, 2016

Need to review and fix errors found by pylint. The errors are mainly or failure handling paths.

msterin-m01:docker-volume-vsphere msterin$ for f in . cli utils ; do  echo === $f ===  ; docker run --rm -v $PWD/esx_service:/code pylint --errors-only  /code/$f ; done
=== . ===
************* Module code.vmdk_ops
/code/vmdk_ops.py:339: [E1205(logging-too-many-args), cleanup_vsan_devfs_path] Too many arguments for logging format string
************* Module code.vmdk_ops_test
/code/vmdk_ops_test.py:566: [E0704(misplaced-bare-raise), ] The raise statement is not inside an except clause
************* Module code.vsan_policy
/code/vsan_policy.py:136: [E1305(too-many-format-args), update_vsan_objects_with_policy] Too many arguments for format string
************* Module code.cli.vmdkops_admin_test
/code/cli/vmdkops_admin_test.py:376: [E1111(assignment-from-no-return), TestStatus.test_status] Assigning to function call which doesn't return
************* Module code.utils.auth
/code/utils/auth.py:76: [E1205(logging-too-many-args), get_tenant] Too many arguments for logging format string
************* Module code.utils.auth_data
/code/utils/auth_data.py:113: [E0602(undefined-variable), DockerVolumeTenant.remove_vms] Undefined variable 'tenenat_id'
/code/utils/auth_data.py:129: [E0602(undefined-variable), DockerVolumeTenant.set_name] Undefined variable 'tenenat_id'
/code/utils/auth_data.py:217: [E0602(undefined-variable), DockerVolumeTenant.set_datastore_access_privileges] Undefined variable 'error_info'
/code/utils/auth_data.py:438: [E0602(undefined-variable), AuthorizationDataManager.create_tables] Undefined variable 'tenant_id'
/code/utils/auth_data.py:674: [E1305(too-many-format-args), AuthorizationDataManager._remove_volumes_for_tenant] Too many arguments for format string
/code/utils/auth_data.py:674: [E0602(undefined-variable), AuthorizationDataManager._remove_volumes_for_tenant] Undefined variable 'dir_path'
************* Module code.utils.convert
/code/utils/convert.py:37: [E0602(undefined-variable), convert_to_MB] Undefined variable 'logging'
************* Module code.utils.kvESX
/code/utils/kvESX.py:272: [E1101(no-member), load] Instance of 'Exception' has no 'errno' member
/code/utils/kvESX.py:275: [E0602(undefined-variable), load] Undefined variable 'EBUSY_RETRY_TIME'
/code/utils/kvESX.py:305: [E1101(no-member), save] Instance of 'Exception' has no 'errno' member
=== cli ===
************* Module code.cli.vmdkops_admin_test
/code/cli/vmdkops_admin_test.py:376: [E1111(assignment-from-no-return), TestStatus.test_status] Assigning to function call which doesn't return
=== utils ===
************* Module code.utils.auth
/code/utils/auth.py:76: [E1205(logging-too-many-args), get_tenant] Too many arguments for logging format string
************* Module code.utils.auth_data
/code/utils/auth_data.py:113: [E0602(undefined-variable), DockerVolumeTenant.remove_vms] Undefined variable 'tenenat_id'
/code/utils/auth_data.py:129: [E0602(undefined-variable), DockerVolumeTenant.set_name] Undefined variable 'tenenat_id'
/code/utils/auth_data.py:217: [E0602(undefined-variable), DockerVolumeTenant.set_datastore_access_privileges] Undefined variable 'error_info'
/code/utils/auth_data.py:438: [E0602(undefined-variable), AuthorizationDataManager.create_tables] Undefined variable 'tenant_id'
/code/utils/auth_data.py:674: [E1305(too-many-format-args), AuthorizationDataManager._remove_volumes_for_tenant] Too many arguments for format string
/code/utils/auth_data.py:674: [E0602(undefined-variable), AuthorizationDataManager._remove_volumes_for_tenant] Undefined variable 'dir_path'
************* Module code.utils.convert
/code/utils/convert.py:37: [E0602(undefined-variable), convert_to_MB] Undefined variable 'logging'
************* Module code.utils.kvESX
/code/utils/kvESX.py:272: [E1101(no-member), load] Instance of 'Exception' has no 'errno' member
/code/utils/kvESX.py:275: [E0602(undefined-variable), load] Undefined variable 'EBUSY_RETRY_TIME'
/code/utils/kvESX.py:305: [E1101(no-member), save] Instance of 'Exception' has no 'errno' member
@msterin msterin self-assigned this Nov 9, 2016
@msterin msterin added this to the 0.9 milestone Nov 9, 2016
@msterin msterin changed the title We have errors found by pylint Need to fix errors found by pylint Nov 9, 2016
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant