Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Tenant Admin CLI may return obsolete VM name #783

Closed
shaominchen opened this issue Nov 28, 2016 · 2 comments
Closed

Tenant Admin CLI may return obsolete VM name #783

shaominchen opened this issue Nov 28, 2016 · 2 comments

Comments

@shaominchen
Copy link
Contributor

Currently we are persisting both VM ID and VM name in the backend database. However, VM name can be changed after the VM was created. If this happens, when user executes Tenant Admin CLI such as "vmdkops_admin tenant ls" or "vmdkops_admin tenant vm ls", the command will return obsolete VM names.

Some possible options to resolve this issue:

  1. Don't persist VM name. Always query VM name at runtime
  2. Still persist VM name. When user executes Tenant CLI queries (i.s. "tenant ls" or "tenant vm ls"), query and return the latest VM name, also update the db if necessary.
@pdhamdhere
Copy link
Contributor

Good catch. We only need to store UUID and convert UUID to VM Name when needed at runtime. See related PR #722

@shaominchen
Copy link
Contributor Author

This issue has already been fixed as part of #828

I have verified the scenario and it works now.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants