vmdk volume should not be created on vsan datastore while passing not compatible VSAN policy or policy content is wrong

[shuklanirdesh82]

Steps to reproduce:

1. create not-compatible vsan policy

vmdkops_admin.py policy create --name notSatisfiable_policy --content '(("proportionalCapacity" i0)("hostFailuresToTolerate" i3))'

2. verifies policy is created or not

[root@sc-rdops-vm02-dhcp-37-215:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py policy ls
Policy Name  Policy Content                                              Active  
-----------  ----------------------------------------------------------  ------  
notSatisfiable_policy           (("proportionalCapacity" i0)("hostFailuresToTolerate" i3))  Unused 

3. create docker volume with the created policy

root@photon-TX4FfW2ET [ ~ ]# docker volume create --driver=vmdk --name=t3 -o vsan-policy-name=notSatisfiable_policy     
t3

vmdkops_admin.py ls
Volume    Datastore      Created By VM                    Created                   Attached To VM  Policy          Capacity  Used     Disk Format  Filesystem Type  Access      Attach As               
--------  -------------  -------------------------------  ------------------------  --------------  --------------  --------  -------  -----------  ---------------  ----------  ----------------------  
t3        vsanDatastore  standalone-c2bea60d2-esx.2-vm.0  Tue Jan 24 00:00:11 2017  detached        [VSAN default]  100.00MB  80.00MB  thin         ext4             read-write  independent_persistent 

Current behavior: volume is created successfully without associating the passed policy and falls back to [VSAN default]

Expectation: volume should not be created while using non-compatible/not-satisfiable policy or when the policy content format is bad

https://github.com/vmware/docker-volume-vsphere/blob/master/esx_service/vmdk_ops.py#L193

# Handle vsan policy
    if kv.VSAN_POLICY_NAME in opts:
        if not vsan_policy.set_policy_by_name(vmdk_path, opts[kv.VSAN_POLICY_NAME]):
            # Drop the failed option
            # A warning is being logged in the called functions
            del opts[kv.VSAN_POLICY_NAME]

on ESX:

*** createVMDK: /vmfs/volumes/vsanDatastore/dockvols/8419cc85-f2b6-4761-a4aa-042814fb3d38/t3.vmdk opts = {'vsan-policy-name': 'notSatisfiable_policy', 'fstype': 'ext4'} 
01/24/17 00:00:11 337757 [standalone-c2bea60d2-esx.2-vm.0-[vsanDatastore] dockvols/8419cc85-f2b6-4761-a4aa-042814fb3d38/t3.vmdk] [WARNING] Failed to set policy for /vmfs/volumes/vsanDatastore/dockvols/8419cc85-f2b6-4761-a4aa-042814fb3d38/t3.vmdk : Failed to set object policy : Out of resources 1835026.

object setPolicy error: Failure 

//CC @msterin @kerneltime @pdhamdhere

[shuklanirdesh82]

Here is the analysis when the policy content is having wrong format.

Policy creation.

[root@sc-rdops-vm02-dhcp-37-215:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py policy create --name silver --content '(("proportionalCapacity" i0)("hostFailuresToTolerate" i0)'
Successfully created policy: silver

vmdk_ops.log

01/23/17 23:57:41 337757 [Thread-22] [INFO   ] cmd create with opts {'vsan-policy-name': 'silver', 'fstype': 'ext4'} on tenant_uuid 8419cc85-f2b6-4761-a4aa-042814fb3d38 datastore vsanDatastore is allowed to execute             
01/23/17 23:57:41 337757 [standalone-c2bea60d2-esx.2-vm.0-[vsanDatastore] dockvols/8419cc85-f2b6-4761-a4aa-042814fb3d38/t2.vmdk] [INFO   ] *** createVMDK: /vmfs/volumes/vsanDatastore/dockvols/8419cc85-f2b6-4761-a4aa-042814fb3d38/t2.vmdk opts = {'vsan-policy-name': 'silver', 'fstype': 'ext4'}
01/23/17 23:57:42 337757 [standalone-c2bea60d2-esx.2-vm.0-[vsanDatastore] dockvols/8419cc85-f2b6-4761-a4aa-042814fb3d38/t2.vmdk] [WARNING] Failed to set policy for /vmfs/volumes/vsanDatastore/dockvols/8419cc85-f2b6-4761-a4aa-042814fb3d38/t2.vmdk : error in line 2: syntax error 
 VSAN_SPBMToVsanPolicy: Failed to convert SPBM string to VsanExpr: Not ready                                                                                                                                                       
Failed to set object policy : Input/output error 327684.                                                                                                                                                                           
object setPolicy error: Failure

[shaominchen]

Over to Liping to take a look.