Wait for attach to complete before trying to format

[kerneltime]

The code to create a volume for vmdk driver does not wait for attach to complete. This can lead to spurious errors.
Sample code where we wait for attach that needs to be added to create https://github.com/vmware/docker-volume-vsphere/blob/5c8203ac74ce7ac3ef0a244c77683d66aa763f27/vmdk_plugin/drivers/vmdk/vmdk_driver.go#L164

[kerneltime]

Test run that seems to have failed due to this https://ci.vmware.run/vmware/docker-volume-vsphere/972

[shaominchen]

Hi Govindan, can you take a look at this issue?

[govint]

Made the changes, will post the PR.

[ashahi1]

Another run on CI with same error:
https://ci.vmware.run/vmware/docker-volume-vsphere/1094

Error log snippet:
2017-02-08 22:54:53.525374578 +0000 UTC [DEBUG] vmdkOps.Get name=dockerVol_1486594493
2017-02-08 22:54:53.573922843 +0000 UTC [DEBUG] vmdkOp.Create name=dockerVol_1486594493
2017-02-08 22:54:55.966148425 +0000 UTC [INFO] Attaching volume and creating filesystem name="dockerVol_1486594493" fstype=ext4
2017-02-08 22:54:55.966195233 +0000 UTC [DEBUG] vmdkOps.Attach name=dockerVol_1486594493
2017-02-08 22:54:56.743269136 +0000 UTC [ERROR] Create filesystem failed, removing the volume name="dockerVol_1486594493" error="Failed to create filesystem on /dev/disk/by-path/pci-0000:0b:00.0-scsi-0:0:2:0: exit status 1. Output = mke2fs 1.42.13 (17-May-2015)\nThe file /dev/disk/by-path/pci-0000:0b:00.0-scsi-0:0:2:0 does not exist and no size was specified.\n"
2017-02-08 22:54:56.743306701 +0000 UTC [DEBUG] vmdkOps.Detach name=dockerVol_1486594493
2017-02-08 22:54:57.161780251 +0000 UTC [DEBUG] vmdkOps.Remove name=dockerVol_1486594493

[ashahi1]

CI run: https://ci.vmware.run/vmware/docker-volume-vsphere/1097

=================================

2017-02-09 00:14:44.928151268 +0000 UTC [DEBUG] vmdkOp.Create name=dockerVol_1486599284
2017-02-09 00:14:48.694338008 +0000 UTC [INFO] Attaching volume and creating filesystem name="dockerVol_1486599284" fstype=ext4
2017-02-09 00:14:48.6943752 +0000 UTC [DEBUG] vmdkOps.Attach name=dockerVol_1486599284
2017-02-09 00:14:49.661459221 +0000 UTC [ERROR] Create filesystem failed, removing the volume name="dockerVol_1486599284" error="Failed to create filesystem on /dev/disk/by-path/pci-0000:0b:00.0-scsi-0:0:2:0: exit status 1. Output = mke2fs 1.42.13 (17-May-2015)\nThe file /dev/disk/by-path/pci-0000:0b:00.0-scsi-0:0:2:0 does not exist and no size was specified.\n"

[govint]

Fixed by #893