Fix for error handling on set command in admin cli.

[govint]

Modified vmdk_ops.py set_vol_opts() to not raise validation errors, surrounding code doesn't raise errors and instead log the errors as warnings. This was the only case where an exception was being raised and un-handled. Plus ValidationError is specific to vmdk_ops.py.

Test is already there for vmdkops_admin.py and vmdk_ops.py for access option.

Code now prints the error and the usage:

vmdkops_admin.py set --options="acces=read-write" --volume=testvol-11@bigone

WARNING:root:Invalid options: ['acces']
Options that can be edited: ['attach-as', 'access']
Failed to update acces=read-write for testvol-11@bigone.

vmdkops_admin.py set --options="access=read-write" --volume=testvol-11@bigone
Successfully updated settings for : testvol-11@bigone

[govint]

Fixes #609

[pdhamdhere]

print ex.message so user knows cause of failure.

[msterin]

+1 on this.
WARNING:root:Invalid options: ['acces'] seems to be showing in the log, not sysout. Or is it in sysout ?
Can you clarify the exact print happening on typos here?

[govint]

The error messages are all on the command line. I'll print the exception
message if any.

On Fri, Oct 7, 2016 at 2:16 AM, Mark Sterin notifications@github.com
wrote:

@msterin commented on this pull request.

In esx_service/cli/vmdkops_admin.py
#610:

@@ -563,10 +563,13 @@ def status(args):

def set_vol_opts(args):

• set_ok = vmdk_ops.set_vol_opts(args.volume, args.options)
• if set_ok:

•    print('Successfully updated settings for : {0}'.format(args.volume))
  

• else:
• try:

•    set_ok = vmdk_ops.set_vol_opts(args.volume, args.options)
  

•    if set_ok:
  

•       print('Successfully updated settings for : {0}'.format(args.volume))
  

•    else:
  

•       print('Failed to update {0} for {1}.'.format(args.options, args.volume))
  

• except Exception as ex:
  print('Failed to update {0} for {1}.'.format(args.options, args.volume))

+1 on this.
WARNING:root:Invalid options: ['acces'] seems to be showing in the log,
not sysout. Or is it in sysout ?
Can you clarify the exact print happening on typos here?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#610, or mute the
thread
https://github.com/notifications/unsubscribe-auth/APHseHcONkwiUdXaZbLru42UwhjonNW8ks5qxV4SgaJpZM4KOrBS
.

[msterin]

@govint - can you please add the current error message (as printed by Admin CLI on this error, and some other error for comparison) so we can LGTM and merge this one ?

[govint]

Updated the change to ensure that exceptions are caught and the exception message is printed

1. Exception handled and error printed on stdout.

[root@localhost:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py set --options="acces=read-write" --volume=testvol-11@bigone
Failed to update acces=read-write for testvol-11@bigone - "Invalid options: ['acces'] \nOptions that can be edited: ['attach-as', 'access']".

1. When the correct option is used
   [root@localhost:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py set --options="access=read-write" --volume=testvol-11@bigone
   Successfully updated settings for : testvol-11@bigone
2. A missing volume
   [root@localhost:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py set --options="access=read-write" --volume=testvol-110@bigone
   WARNING:root:Volume testvol-110 not found.
   Failed to update access=read-write for testvol-110@bigone.

[msterin]

Fixes #609