Fixed error on parsing PID for status command.

[govint]

Also added a unit test for status command.

[govint]

Fixes #633

[msterin]

CI fails in what seems to be related areas, will take a look when CI passes.
meanwhile - can you elaborate on what was the error (output before/after the fix) and what config is needed to repro ?

[msterin]

please add a comment with expected result example (makes easy to understand and check the code).

[govint]

This was the error:

File "/usr/lib/vmware/vmdkops/bin/vmdkops_admin.py", line 594, in get_service_status
pid = output[3].split("=")[1]
TypeError: a bytes-like object is required, not 'str'

[msterin]

that's OK - but can you please add a comment (in the code) with the example of output so the output[3].split("=")[1] becomes clear ?

[govint]

Sure, and this is the fixed output:

python /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py status
Version: 0.7.3f2c66a-0.0.1
Status: Running
Pid: 5585696
Port: 1019
LogConfigFile: /etc/vmware/vmdkops/log_config.json
LogFile: /var/log/vmware/vmdk_ops.log

[msterin]

the fix looks good and good to go when CI passes

[pdhamdhere]

You may want to check CI, vmdkopsAdmin testStatus test is failing.

[govint]

Its a different test thats failing (vmdkops_admin_sanity_test.py), the new
test was added to vmdkops_admin_test.py

On Tue, Oct 25, 2016 at 9:39 AM, Govindan T tgovin1@gmail.com wrote:

Restarted CI test for this change I'll check and update.

On Tue, Oct 25, 2016 at 9:34 AM, Prashant Dhamdhere <
notifications@github.com> wrote:

You may want to check CI, vmdkopsAdmin testStatus test is failing.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#641 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APHseMor7tefqvnaK96fKbK-JevIC19aks5q3X-5gaJpZM4Kerhw
.

[govint]

More byte to string handling in test code. Fixed.

On Tue, Oct 25, 2016 at 10:05 AM, Govindan T tgovin1@gmail.com wrote:

Its a different test thats failing (vmdkops_admin_sanity_test.py), the
new test was added to vmdkops_admin_test.py

On Tue, Oct 25, 2016 at 9:39 AM, Govindan T tgovin1@gmail.com wrote:

Restarted CI test for this change I'll check and update.

On Tue, Oct 25, 2016 at 9:34 AM, Prashant Dhamdhere <
notifications@github.com> wrote:

You may want to check CI, vmdkopsAdmin testStatus test is failing.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#641 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APHseMor7tefqvnaK96fKbK-JevIC19aks5q3X-5gaJpZM4Kerhw
.

[govint]

Restarted CI test for this change I'll check and update.

On Tue, Oct 25, 2016 at 9:34 AM, Prashant Dhamdhere <
notifications@github.com> wrote:

You may want to check CI, vmdkopsAdmin testStatus test is failing.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#641 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APHseMor7tefqvnaK96fKbK-JevIC19aks5q3X-5gaJpZM4Kerhw
.

[pdhamdhere]

LGTM