This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Include the ssh keys to be used in container. #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msterin
approved these changes
Oct 27, 2016
msterin
reviewed
Oct 27, 2016
| @@ -152,8 +152,8 @@ test: test-esx build | |||
|
|
|||
| # test-esx is a quick unittest for ESX Python code. | |||
| # Deploys, runs and clean unittests (i.e. all files *_test.py) on ESX | |||
| SSH := $(DEBUG) ssh -kTax -o StrictHostKeyChecking=no | |||
| SCP := $(DEBUG) scp -r -q -o StrictHostKeyChecking=no | |||
| SSH := $(DEBUG) ssh $(SSH_KEY_OPT) -kTax -o StrictHostKeyChecking=no | |||
There was a problem hiding this comment.
line 48 in drone.yml
kerneltime
force-pushed
the
runci/debug.kerneltime
branch
2 times, most recently
from
8deb9fa
to
ce12a7f
Compare
SSH keys need to be encrypted and stored in .drone.sec
kerneltime
force-pushed
the
runci/debug.kerneltime
branch
from
ce12a7f
to
b7915fd
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the updated final fix. SSH key management is in line with what drone recommends.
SSH key to be used is part of .drone.sec and decrypted and used during build.