getVmdk needs to return correct JSON error, and print more info in error case #661

msterin · 2016-10-29T00:02:05Z

if "getVmdk" error was hit, it was not returning proper json message. Now it does.
Tested by manually corrupting KV file and running docker volume inspect <vol>

Output:

root@photon-1uL8XNsuB [ ~ ]# docker volume inspect ty1
[]
Error response from daemon: get ty1: VolumeDriver.Get: Failed to get disk details for /vmfs/volumes/datastore1/dockvols/ty1.vmdk ('created-by')

pdhamdhere

Lgtm

Now getVmdk returns correct JSON error, and prints more info

1fe25f1

vmwclabot added the cla-not-required label Oct 29, 2016

pdhamdhere approved these changes Oct 29, 2016

View reviewed changes

msterin merged commit d618cff into master Oct 29, 2016

msterin deleted the err-in-get.msterin branch October 29, 2016 00:29

msterin mentioned this pull request Oct 29, 2016

Corrupted metadata file should be handled gracefully and not terminate operations #662

Closed

msterin changed the title ~~Now getVmdk returns correct JSON error, and prints more info~~ getVmdk needs to return correct JSON error, and print more info in error case Oct 29, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

getVmdk needs to return correct JSON error, and print more info in error case #661

getVmdk needs to return correct JSON error, and print more info in error case #661

msterin commented Oct 29, 2016

pdhamdhere left a comment

getVmdk needs to return correct JSON error, and print more info in error case #661

getVmdk needs to return correct JSON error, and print more info in error case #661

Conversation

msterin commented Oct 29, 2016

pdhamdhere left a comment

Choose a reason for hiding this comment