This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Quick fix for broken tenant commands in admin CLI #669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the last merge (threading support in vmdk_ops) we accidentally broke
tenant
commands in admin CLI. No, they did not have unit test coverage - and this will be addressed in a separate PR (Issue #668 - The same PR will also take care of re-using the get_auth_mgt() function from auth.py)This PR applies a quick bandaid by defining the missing function and moving it (and related _auth_mgr) global to admin CLI code.
// @shaominchen @lipingxue
Tested: manually. Was throwing exception before the fix. Now does the following: