This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Bring in the UI work #702
Merged
Bring in the UI work #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdhamdhere
reviewed
Nov 4, 2016
| "url" : "https://github.com/vmware/docker-volume-vsphere.git" | ||
| }, | ||
| "author": { | ||
| "name": "Mark Soper", |
There was a problem hiding this comment.
We generally avoid individual's name in code/repository. I would suggest to replace with following;
name = SABU, VMware
email = cna-storage@vmware.com
url = https://github.com/vmware/docker-volume-vsphere
| // Here when the app is loaded we're temporarily making | ||
| // a call to DvolVsanService to test connectivity | ||
| // | ||
| // TODO: remove this |
There was a problem hiding this comment.
I assume this will be removed at later point when UI is fully integrated with backend.
|
Merging this change in. From here on, UI changes should be incremental small PRs. |
|
Fixes #637 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for UI work from @marksoper.
To build the UI code run