Run pylint as a part of the ESX build #739
Conversation
Does it mean,simple "make" on my dev box won't run pylint? IMO, it should run by default and not restricted to CI runs triggered by drone. |
| # Dockerfile for running pylint | ||
| # | ||
| FROM alpine | ||
| MAINTAINER "CNA Storage Team" <cnastorage@vmware.com> |
| @@ -0,0 +1,355 @@ | |||
| [MASTER] | |||
There was a problem hiding this comment.
Is it tuned to check for both Python 2.x and Python 3.x?
There was a problem hiding this comment.
2.0 and bilingual (with module 'six') it looks like pylint for py3 will require a separate container. I'll see if it can be done with Py3/bilingual support
'make' will run pylint because 'make' runs default target (dockerbuild) and |
msterin
force-pushed
the
runci/pylint-on-build.msterin
branch
from
2d0ac31
to
d7c54d6
Compare
| @@ -68,3 +68,6 @@ endif | |||
| # redirect all | |||
| $(TARGETS): | |||
| $(MAKE) --directory=vmdk_plugin $@ | |||
|
|
|||
| .DEFAULT: | |||
There was a problem hiding this comment.
What is the role of this target given that we define the default target earlier in the file?
There was a problem hiding this comment.
"default target" earlier is the target which is invoked by default :-) , i.e. on make command, with no targets.
.DEFAULT: is rule set of last resort - executed when target is passed but not found in Makefile. Real good for fall through.
https://www.gnu.org/software/make/manual/html_node/Special-Targets.html says:
.DEFAULT
The recipe specified for .DEFAULT is used for any target for which no rules are found (either
explicit rules or implicit rules). See Last Resort. If a .DEFAULT recipe is specified, every file
mentioned as a prerequisite, but not as a target in a rule, will have that recipe executed on its
behalf. See Implicit Rule Search Algorithm.
|
|
||
| CMD ["/code"] | ||
|
|
There was a problem hiding this comment.
Get ride of the empty lines.
Currently it will fail the build if there are errors (e.g. wrong arg count, etc...) Going forward , we need to make it more strict up to and including format/PEP8
msterin
force-pushed
the
runci/pylint-on-build.msterin
branch
from
d7c54d6
to
e8d3d0f
Compare
Pylint (in a container) is run automatically on 'make dockerbuild' (default target) and in Drone.
If you want to run it on your box with no containers, "make pylint".
Currently it will fail the build if only there are errors (e.g. wrong arg count, etc...). It ignores all the rest (esx_service/Makefile is setting 'PYLINT_IGNORE := --errors-only -d import-error,no-name-in-module')
Going forward , we will make it more strict up to and including failing on naming convention violation, whitespaces and other PEP8 formatting exectations
testing: