Get attached VM name for attached volume in admin CLI #745
Conversation
| def vm_uuid2name(vm_uuid): | ||
| vm = findVmByUuid(vm_uuid) | ||
| if vm: | ||
| return vm.config.name |
There was a problem hiding this comment.
it does not return anything if not vm. It's OK in python (will just return None) but it looks unpleasant.
Something like this reads easier IMO . at any rate, your call as the result is correct
if not vm or not vm.config:
return None
return vm.config.name| vm_name = vmdk_ops.vm_uuid2name(metadata[kv.ATTACHED_VM_UUID]) | ||
| if not vm_name: | ||
| return kv.DETACHED | ||
| else: |
There was a problem hiding this comment.
nit: 'else' is not needed IMO
|
Updated changes to address review comments. Tried running with Python 3.5 and there are exception and print statements that are incompatible. Fixed those also. |
kerneltime
force-pushed
the
fix-admin
branch
from
703710c
to
b6ad3f8
Compare
|
@govint - the actual fix looks good and ready to merge. The changes related to whitespaces and fixing For now, let's merge when/if CI passes , since it's a fairly small set of changes and the commit is already squashed, but please - do not mix different work in the same commit. Also, I am planning to do a pass on Py3/whitespaces work, so please do not do anymore fixes in this area to avoid conflicts without pinging me. |
|
Sure, I couldn't run on 6.5 which I have here as a test bed and hence had On Thu, Nov 17, 2016 at 11:57 PM, Mark Sterin notifications@github.com
|
|
Fixes #738 |
Modified to get the VM name for attached disks from VM UUID.
...
snap-disk1 bigone Ubuntu-16-04 Wed Nov 9 12:43:47 2016 detached N/A 100.00MB 17.00MB ext4 read-write persistent
clonedisk bigone photon-custom-hw10-1.0-13c08b6 Fri Oct 28 07:12:04 2016 detached N/A 100.00MB 100.00MB ext4 read-write independent_persistent
try-attach bigone 1 Thu Nov 17 05:10:33 2016 detached N/A 100.00MB 15.00MB ext4 read-write independent_persistent
docker run --rm -it -w /data -v try-attach:/data busybox
/data #
...
snap-disk1 bigone Ubuntu-16-04 Wed Nov 9 12:43:47 2016 detached N/A 100.00MB 17.00MB ext4 read-write persistent
clonedisk bigone photon-custom-hw10-1.0-13c08b6 Fri Oct 28 07:12:04 2016 detached N/A 100.00MB 100.00MB ext4 read-write independent_persistent
try-attach bigone 1 Thu Nov 17 05:10:33 2016 1 N/A 100.00MB 15.00MB ext4 read-write independent_persistent