-
Notifications
You must be signed in to change notification settings - Fork 95
Adding support to use current build number while running tests #761
Adding support to use current build number while running tests #761
Conversation
Are these changes complete? |
refcnt_test.go is having its own unique name for volume creation and I have supplied for the rest. |
} | ||
} | ||
|
||
fmt.Printf("Running parallel tests on %s and %s (may take a while)...\n", endPoint1, endPoint2) | ||
// Create a short buffered channel to introduce random pauses | ||
results := make(chan error, parallelVolumes) | ||
createRequest := types.VolumeCreateRequest{ | ||
Name: volumeName, | ||
Name: volName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change.
The volume name generation should be also changed in the goroutine below to something like:
createRequest.Name += strconv.Itoa(idx) + strconv.Itoa(i)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I will update in the next diff.
Please add how did you test the change (I guess a grep for the log would be good). |
48a342a
to
233a6c6
Compare
4e8a8d4
to
7a5769e
Compare
Addressed all previous comment and verified through CI run (https://ci.vmware.run/vmware/docker-volume-vsphere/518) .. code is ready for review. |
Supplying a fix for #509 "Test runs should be isolated in namespace"
-----local test run logs -------
Parameter passed from Makefile