This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Log open volume descriptors in busy errors #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kvESX.load/save: log volume open descriptors vmdk_ops: Use VMDK_RETRY_* constants from vmdk_utils vmdk_ops.removeVMDK: log volume open descriptors vmdk_utils: Add log_volume_lsof(), for logging open descriptors matching the volume name vmdk_utils: Add get_volname_from_vmdk_path() vmdk_utils: Add VMDK_RETRY_* constants
brunotm
force-pushed
the
brunotm.vsan-dbg
branch
from
c41116b
to
d207ba4
Compare
|
A side note on the removal of the verification of errno attribute ((hasattr(open_error, "errno")) on the retry loops in kvESX, is that before we're catching a general Exception and would just error out if it didn't had the errno attribute. After the @msterin #725 change we're catching only IOError that always have the errno attribute so that check isn't needed anymore. |
govint
approved these changes
Nov 26, 2016
|
@kerneltime @govint |
|
@kerneltime |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
//CC @kerneltime @govint
Related with the investigation of #768