This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Include hostd logs on failure only #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msterin
approved these changes
Nov 28, 2016
|
Looks like the CI console log size will not change without a CI software upgrade. The sw upgrade to 0.5 is not planned yet as it is still not GAed. |
lipingxue
reviewed
Nov 28, 2016
| @@ -36,5 +36,8 @@ truncate_vm_logs() { | |||
|
|
|||
| truncate_esx_logs() { | |||
| $SSH $USER@$1 "echo > $ESX_LOGFILE" | |||
| $SSH $USER@$1 "echo > $HOSTD_LOGFILE" | |||
| if [ $INCLUDE_HOSTD == "true" ] | |||
| this | |||
There was a problem hiding this comment.
Why do we need this line?
kerneltime
force-pushed
the
runci/hostd-on-failure.kerneltime
branch
from
9f17f5b
to
cf79d5a
Compare
|
Thanks, updated |
kerneltime
force-pushed
the
runci/hostd-on-failure.kerneltime
branch
from
cf79d5a
to
3759c61
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to large log files, the console output gets truncated. I am working with CI folks to bump up the limit but for successful runs, hostd log is a distraction. Thus, only dump hostd logs on failures.
Testing:
Faked a CI failure https://ci.vmware.run/vmware/docker-volume-vsphere/505
Fixes #769