Update admin-cli.md #838

lipingxue · 2016-12-22T18:39:21Z

Update user guide (admin-cli.md) accordingly after the DEFAULT_TENANT, DEFAULT_PRIVILEGE, and DEFAULT_DATASTORE change are introduced.

update existing samples with the latest command output
add a section about new command "tenant update"
update the description of command "tenant access add" regarding the "default_datastore" management.

lipingxue · 2016-12-22T18:39:46Z

@pdhamdhere @kerneltime Please review it.

kerneltime · 2016-12-22T18:42:28Z

docs/user-guide/admin-cli.md


 optional arguments:
  -h, --help            show this help message and exit
 ```

 ### Create
+A tenant named "_DEFAULT" should have been created by system automatically before users try to create any tenant.


A tenant named "_DEFAULT" should have been created by system automatically before users try to create any tenant. => A tenant named "_DEFAULT" will be created automatically post install.

kerneltime · 2016-12-22T18:45:48Z

We need a small write up of the default tenant behavior here
It should explain that default tenant is created.. what is the behavior for default tenant for datastores, when and what should a VM that gets assigned to default tenant expect..

kerneltime · 2016-12-22T18:45:57Z

Will continue to review.

msterin

LGTM + a couple of small corrections

msterin · 2016-12-22T18:59:20Z

docs/user-guide/admin-cli.md

@@ -93,35 +99,100 @@ optional arguments:
  -h, --help  show this help message and exit
 ```

+### Update
+Update existing tenant. This command allows to update "Description", "Default_datastore" or rename an existing tenant.


This command allows to update "Description" and "Default_datastore" fields, or rename an existing tenant.

msterin · 2016-12-22T19:01:04Z

docs/user-guide/admin-cli.md

-                        Datastore access Permissions granted: Choices =
-                        ['create', 'delete', 'mount', 'all']
-  --name NAME           Tenant name
+  --allow-create        Allow create and delete on datastore if set to True


the datastore to be consistent with other help

lipingxue · 2016-12-22T19:30:15Z

@kerneltime
Mark has a detailed design about default_tenant, default_privilege and default_datastore here. #621
Please take a look. Should we just put a link to this document in tenancy.md or we can write a short paragraph based on this document.

…_datastore in tenancy.md.

lipingxue · 2016-12-22T22:21:30Z

Address comments fro Ritesh. A small write up of the default tenant behavior is added.

kerneltime · 2016-12-22T23:58:46Z

docs/features/tenancy.md

@@ -17,6 +17,21 @@ limits at granularity of datastore.

 Tenants can be created and managed via the [Admin CLI](/user-guide/admin-cli/#tenant)

+## Default tenant
+When a VM which does not belong to any tenant issues a request to vmdk_ops, this VM will be assumed to be in _DEFAULT tenant, and will get privileges 
+associated with this tenant. \_DEFAULT tenant will be automatically created by system post install, so by default vmdk_ops will support request from 


typo? _Default => _Default?

kerneltime · 2016-12-23T00:00:43Z

docs/user-guide/admin-cli.md

----------  -------------  -------------  ------------  ---------------  ----------
-datastore1  1              1              1             500.00GB         2.00TB
+[root@localhost:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py tenant access ls --name=tenant1
+Datastore   Allow_create  Max_volume_size  Total_size  


White space at the end

kerneltime · 2016-12-23T00:00:51Z

docs/user-guide/admin-cli.md

-datastore1  1              1              1             500.00GB         2.00TB
+[root@localhost:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py tenant access ls --name=tenant1
+Datastore   Allow_create  Max_volume_size  Total_size  
+----------  ------------  ---------------  ----------  


Here as well

kerneltime

some minor nits need addressing. LGTM

shuklanirdesh82

few Nits to keep it consistent with other help

shuklanirdesh82 · 2016-12-23T04:04:12Z

docs/user-guide/admin-cli.md

 usage: vmdkops_admin.py tenant create [-h] --name NAME
+                                      [--description DESCRIPTION]
                                      [--vm-list vm1, vm2, ...]

 optional arguments:
  -h, --help            show this help message and exit


Nit: show => Show (to keep it consistent with the rest)

shuklanirdesh82 · 2016-12-23T04:05:08Z

docs/user-guide/admin-cli.md

+                                      [--new-name NEW_NAME]
+
+optional arguments:
+  -h, --help            show this help message and exit


nit: same as above

shuklanirdesh82 · 2016-12-23T04:05:27Z

docs/user-guide/admin-cli.md

+usage: vmdkops_admin.py tenant rm [-h] --name NAME [--remove-volumes]
+
+optional arguments:
+  -h, --help        show this help message and exit


nit: same as above

lipingxue added 3 commits December 22, 2016 10:17

First checkin to change admin-cli document for tenant command.

bd8dc86

Add description for "tenant update command".

e66fe19

Some wording change.

890415d

vmwclabot added the cla-not-required label Dec 22, 2016

kerneltime reviewed Dec 22, 2016

View reviewed changes

msterin approved these changes Dec 22, 2016

View reviewed changes

lipingxue added 3 commits December 22, 2016 14:08

Add description about _DEFAULT tenant, _DEFAULT privilege and default…

d8aad99

…_datastore in tenancy.md.

Add a missing period.

acdd7b3

Formatting the document.

f312242

kerneltime reviewed Dec 22, 2016

View reviewed changes

kerneltime reviewed Dec 23, 2016

View reviewed changes

kerneltime approved these changes Dec 23, 2016

View reviewed changes

Address comments from Ritesh.

fc9be86

shuklanirdesh82 suggested changes Dec 23, 2016

View reviewed changes

lipingxue merged commit 67cabe4 into master Dec 23, 2016

msterin deleted the tenant_document.liping branch January 10, 2017 07:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update admin-cli.md #838

Update admin-cli.md #838

lipingxue commented Dec 22, 2016

lipingxue commented Dec 22, 2016

kerneltime Dec 22, 2016

kerneltime commented Dec 22, 2016

kerneltime commented Dec 22, 2016

msterin left a comment

msterin Dec 22, 2016

msterin Dec 22, 2016

lipingxue commented Dec 22, 2016

lipingxue commented Dec 22, 2016

kerneltime Dec 22, 2016 •

edited

Loading

kerneltime Dec 23, 2016

kerneltime Dec 23, 2016

kerneltime left a comment

shuklanirdesh82 left a comment

shuklanirdesh82 Dec 23, 2016

shuklanirdesh82 Dec 23, 2016

shuklanirdesh82 Dec 23, 2016

Update admin-cli.md #838

Update admin-cli.md #838

Conversation

lipingxue commented Dec 22, 2016

lipingxue commented Dec 22, 2016

Choose a reason for hiding this comment

kerneltime commented Dec 22, 2016

kerneltime commented Dec 22, 2016

msterin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lipingxue commented Dec 22, 2016

lipingxue commented Dec 22, 2016

kerneltime Dec 22, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kerneltime left a comment

Choose a reason for hiding this comment

shuklanirdesh82 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kerneltime Dec 22, 2016 •

edited

Loading