This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Supplying a fix for "#836: vm creation is failing on vsanDatastore" #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
approved these changes
Dec 22, 2016
msterin
suggested changes
Dec 22, 2016
| # bare minimum VM shell, no disks. Feel free to edit | ||
| vmx_file = vim.vm.FileInfo(logDirectory=None, | ||
| snapshotDirectory=None, | ||
| suspendDirectory=None, | ||
| vmPathName=datastore_path) | ||
| vmPathName='[' + datastore + '] ') |
There was a problem hiding this comment.
Please rename create_vm param from datastore to vm_path and it will be good to go
There was a problem hiding this comment.
Sure, Thanks!
shuklanirdesh82
force-pushed
the
vmCreationOnVsanFix.shuklanirdesh82
branch
from
59381b4
to
697becf
Compare
…anDatastore" Addressing Mark's comment (renaming method parameter to more meaningful name) Correcting the lint errors
shuklanirdesh82
force-pushed
the
vmCreationOnVsanFix.shuklanirdesh82
branch
from
697becf
to
8ef06a5
Compare
msterin
approved these changes
Dec 22, 2016
| @@ -479,7 +476,7 @@ def setUp(self): | |||
| si = vmdk_ops.get_si() | |||
| error, self.vm = create_vm(si=si, | |||
| vm_name=self.vm_name, | |||
| datastore=self.datastore_name) | |||
| vm_path=self.datastore_name) | |||
There was a problem hiding this comment.
this is still weird... why self.datastore_name actually keep the vm_path ?
I'll approve to unbock , but please investigate as a separate item
There was a problem hiding this comment.
Actually create_vm is internally prepares vm_path (vmHome) i.e. vm_path = datastore_name + vmDisplayName.
So I am going to rename it with 'datastore_name' with more meaningful name to reduce the confusion.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vm creation was not complaining for vmfs as it doesn't use osfs code path and fails only for vsan as it is objectBased FS and vm-name was appending twice hence the issue.
Testing Done: Yes (both on vsan and vmfs)
vmdk_ops_test.py tests are passing locally and able to create vm successfully.
//CC @ashahi1 @shaominchen